https://bugzilla.redhat.com/show_bug.cgi?id=2448590
Daniel Berrangé <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?([email protected] | |om) | --- Comment #4 from Daniel Berrangé <[email protected]> --- (In reply to Marc-Andre Lureau from comment #3) > - Should use Provides: bundled() > (https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling), or > not? That is all automatically added.... except I lost the copying of 'package.json' into the RPM so it didn't happen > - pccs_server.js not installed, what is the package doing? :) That's the other file I lost copying of. Guess I messed up when rebasing from 1.24 to 1.25 just before uploading and failed to retest :-( > - it looks like node_sqlite3 module is built but not using > %{optflags}/CFLAGS/CXXFLAGS, to be checked The build is not verbose so we can't see it currently, but when I make it verbose it shows g++ -o Debug/obj.target/node_sqlite3/src/backup.o ../src/backup.cc '-DNODE_GYP_MODULE_NAME=node_sqlite3' '-DUSING_UV_SHARED=1' '-DUSING_V8_SHARED=1' '-DV8_DEPRECATION_WARNINGS=1' '-D_GLIBCXX_USE_CXX11_ABI=1' '-D_FILE_OFFSET_BITS=64' '-D_LARGEFILE_SOURCE' '-D__STDC_FORMAT_MACROS' '-DNAPI_VERSION=10' '-DNAPI_DISABLE_CPP_EXCEPTIONS=1' '-DBUILDING_NODE_EXTENSION' '-DDEBUG' '-D_DEBUG' -I/var/home/berrange/.cache/node-gyp/22.22.0/include/node -I/var/home/berrange/.cache/node-gyp/22.22.0/src -I/var/home/berrange/.cache/node-gyp/22.22.0/deps/openssl/config -I/var/home/berrange/.cache/node-gyp/22.22.0/deps/openssl/openssl/include -I/var/home/berrange/.cache/node-gyp/22.22.0/deps/uv/include -I/var/home/berrange/.cache/node-gyp/22.22.0/deps/zlib -I/var/home/berrange/.cache/node-gyp/22.22.0/deps/v8/include -I/var/home/berrange/src/fedora/sgx-pccs/sgx-pccs-1.25-build/confidential-computing.tee.dcap.pccs-DCAP_1.25/service/node_modules/node-addon-api -I/usr/include -fPIC -pthread -Wall -Wextra -Wno-unused-parameter -fPIC -m64 -g -O0 -fno-rtti -fno-strict-aliasing -std=gnu++17 -MMD -MF ./Debug/.deps/Debug/obj.target/node_sqlite3/src/backup.o.d.raw -O2 -flto=auto -ffat-lto-objects -fexceptions -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -march=x86-64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -mtls-dialect=gnu2 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -c which looks like the required CFLAGS, so I think we're good. I'll add V=1 to the spec so this is recorded in logs. > - the license files are put under node_modules/. Drop" mkdir > ../node_module_licenses" ? Yep, that's left over cruft > - SOURCE50 -> SOURCE1 Yep. > - instead of hardcoding lib64, perhaps use %{_libdir} instead? We can't use %{_libdir} in this context, but %{_lib} is suitable. > - yhaving → having Yep > - sgx-pccs-admin missing %{?_isa} versioned dependency Yep > What distribution/release do you target? If rhel9 and others must be > supported, maybe setup a copr to check the various configurations? There is a little bit of code copied over from linux-sgx.spec that targets RHEL-9, but it is still TBD if I'll pull this into RHEL-9 or not. If I don't then the conditionals will get dropped eventually. The changes are at the same URLs Spec URL: https://berrange.fedorapeople.org/review/sgx-pccs/sgx-pccs.spec SRPM URL: https://berrange.fedorapeople.org/review/sgx-pccs/sgx-pccs-1.25-1.fc45.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2448590 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202448590%23c4 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
