https://bugzilla.redhat.com/show_bug.cgi?id=2448590
Marc-Andre Lureau <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?([email protected] | |om) --- Comment #3 from Marc-Andre Lureau <[email protected]> --- - Should use Provides: bundled() (https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling), or not? - pccs_server.js not installed, what is the package doing? :) - it looks like node_sqlite3 module is built but not using %{optflags}/CFLAGS/CXXFLAGS, to be checked - the license files are put under node_modules/. Drop" mkdir ../node_module_licenses" ? - SOURCE50 -> SOURCE1 - instead of hardcoding lib64, perhaps use %{_libdir} instead? - yhaving → having - sgx-pccs-admin missing %{?_isa} versioned dependency What distribution/release do you target? If rhel9 and others must be supported, maybe setup a copr to check the various configurations? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2448590 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202448590%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
