https://bugzilla.redhat.com/show_bug.cgi?id=2417806
--- Comment #43 from Cristian Le <[email protected]> --- (In reply to Andreas Haupt from comment #42) > I would still recommend bat, as it's the best choice for colored output. > Would you agree with this? > > ``` > # needed for colored output > Recommends: bat > ``` No, that is a decision for Fedora to make via ChangeProposals, and because `lesspipe` has the possibility of being installed on all systems depending on how this review goes, you **must** keep it to the bare minimum for now. You can propose adding `bat` to the systems in a separate proposal, but please not in here. > I will remove the current `Suggests:` which are actually needed for pdf > display and vimcolor, if you insist ;-) Comment above applies to this. > Those have been removed as `Suggests:` already. They are still there as > `BuildRequires:` as it was stated here that most of the available tests from > test.sh should also run/succeed instead of just being ignored due to missing > binaries. It seems weird at first glance, but looking at the implementation it is indeed required. Some comments on where to find the usage can be helpful for others who would come to help with the maintenance if there is any cleanup needed. You would also have to consider balancing the dependencies that may make this package rebuild when those are bumped. In Fedora infra we have the `tmt` test backend where you could move some of the tests, and afaict this package would be quite easy to do so. > Is this all? From my side, yes. But I am not familiar enough with the project to know what could have been missed. But there is still the compatibility with `less` that we either need the collaboration or the epel-only packaging. And the reviewer here, which I did not take since I think either Peter or Steve would want to see it through the final review as they had some open concerns. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2417806 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202417806%23c43 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
