https://bugzilla.redhat.com/show_bug.cgi?id=2417806
Andreas Haupt <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?([email protected] | |om) Keywords|AutomationTriaged | --- Comment #42 from Andreas Haupt <[email protected]> --- (In reply to Cristian Le from comment #41) > @Andreas, the Recommends/Suggests that the author provided are also > orthogonal with whether they should be in the spec file. Unless these > actively affect the execution of `lesspipe`, please remove them, otherwise > please explain in more detail how they are linked to `lesspipe`. > `libreoffice`, `pandoc` etc. do not seem relevant. Those have been removed as `Suggests:` already. They are still there as `BuildRequires:` as it was stated here that most of the available tests from test.sh should also run/succeed instead of just being ignored due to missing binaries. I would still recommend bat, as it's the best choice for colored output. Would you agree with this? ``` # needed for colored output Recommends: bat ``` I will remove the current `Suggests:` which are actually needed for pdf display and vimcolor, if you insist ;-) > Also please avoid using the `Requires: /usr/bin/*` and instead depend on the > actual packages that provide them. This would avoid issues when multiple > packages provide the same named binary, changes in the filestructure, etc. OK, will do this: ``` Requires: procps-ng ``` instead of: ``` Requires: /usr/bin/ps ``` Is this all? Thanks for your time, Andreas -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2417806 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202417806%23c42 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
