https://bugzilla.redhat.com/show_bug.cgi?id=2437502
Fabio Porcedda <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #116 from Fabio Porcedda <[email protected]> --- Hi, as part of my Fedora packager sponsorship process, this is my mock review using the .spec and .src.rpm files submitted in this Bugzilla. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Remove duplicated "BuildRequires: gcc" - Explicit dependency must not be used if they already included automatically like so remove all Requires: - Write all comments in english, 3 of them are in italian - %autorelease andh %autochangelog should be used - Why "make clean" is needed? Are not upstream sources already cleaned up? If not should be better to just fix upstream? - install should be used instead of cp "cp -r readme_assets/*.." - Copyright indication must be not used anymore it has been replaced by the License line - the .desktop file should be installed using desktop-file-install - Suggestion: include the .desktop file upstream instead of generating it in the spec - README.md tells to use run_server.sh and run_client.sh but they are not included in the rpm, is the README.md wrong? ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GNU General Public License v3.0 or later", "Unknown or generated", "GNU General Public License, Version 3", "Creative Commons Attribution 4.0 and/or GNU General Public License, Version 3". 75 files have unknown license. Detailed output of licensecheck in /home/fabio/fedora/spacegl/tmp/2437502-spacegl/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries or specifies bundled libraries with Provides: bundled(<libname>) if unbundling is not possible. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [!]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 378856 bytes in 3 files. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in spacegl- data [!]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. s390x arch is still pending for the outage [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: spacegl-2026.02.09-24.fc45.x86_64.rpm spacegl-data-2026.02.09-24.fc45.noarch.rpm spacegl-2026.02.09-24.fc45.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpr7f8ulkp')] checks: 32, packages: 3 spacegl.x86_64: W: no-manual-page-for-binary spacegl-client spacegl.x86_64: W: no-manual-page-for-binary spacegl-server spacegl.x86_64: W: no-manual-page-for-binary spacegl_3dview spacegl.x86_64: W: no-manual-page-for-binary spacegl_client spacegl.x86_64: W: no-manual-page-for-binary spacegl_hud spacegl.x86_64: W: no-manual-page-for-binary spacegl_server spacegl.x86_64: W: no-manual-page-for-binary spacegl_viewer spacegl.x86_64: W: no-manual-page-for-binary spacegl_vulkan spacegl-data.noarch: W: no-documentation spacegl.spec:123: W: macro-in-%changelog %{rel} 3 packages and 0 specfiles checked; 0 errors, 10 warnings, 14 filtered, 0 badness; has taken 6.5 s Rpmlint (debuginfo) ------------------- Checking: spacegl-debuginfo-2026.02.09-24.fc45.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpvyemwr8a')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 20 filtered, 0 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.8.0 configuration: /usr/lib/python3.14/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 spacegl.x86_64: W: unused-direct-shlib-dependency /usr/bin/spacegl_3dview /lib64/libcrypto.so.3 spacegl.x86_64: W: unused-direct-shlib-dependency /usr/bin/spacegl_3dview /lib64/libgomp.so.1 spacegl.x86_64: W: unused-direct-shlib-dependency /usr/bin/spacegl_client /lib64/libm.so.6 spacegl.x86_64: W: unused-direct-shlib-dependency /usr/bin/spacegl_client /lib64/libgomp.so.1 spacegl.x86_64: W: unused-direct-shlib-dependency /usr/bin/spacegl_hud /lib64/libcrypto.so.3 spacegl.x86_64: W: unused-direct-shlib-dependency /usr/bin/spacegl_hud /lib64/libgomp.so.1 spacegl.x86_64: W: unused-direct-shlib-dependency /usr/bin/spacegl_viewer /lib64/libcrypto.so.3 spacegl.x86_64: W: unused-direct-shlib-dependency /usr/bin/spacegl_viewer /lib64/libm.so.6 spacegl.x86_64: W: unused-direct-shlib-dependency /usr/bin/spacegl_viewer /lib64/libgomp.so.1 spacegl.x86_64: W: unused-direct-shlib-dependency /usr/bin/spacegl_vulkan /lib64/libcrypto.so.3 spacegl.x86_64: W: unused-direct-shlib-dependency /usr/bin/spacegl_vulkan /lib64/libgomp.so.1 spacegl.x86_64: W: no-manual-page-for-binary spacegl-client spacegl.x86_64: W: no-manual-page-for-binary spacegl-server spacegl.x86_64: W: no-manual-page-for-binary spacegl_3dview spacegl.x86_64: W: no-manual-page-for-binary spacegl_client spacegl.x86_64: W: no-manual-page-for-binary spacegl_hud spacegl.x86_64: W: no-manual-page-for-binary spacegl_server spacegl.x86_64: W: no-manual-page-for-binary spacegl_viewer spacegl.x86_64: W: no-manual-page-for-binary spacegl_vulkan spacegl-data.noarch: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 20 warnings, 35 filtered, 0 badness; has taken 1.5 s Source checksums ---------------- https://github.com/nicolataibi/spacegl/archive/refs/tags/2026.02.09-24.tar.gz : CHECKSUM(SHA256) this package : 4a9bf4ed52db483ed419468e5824d335463b707793c1bf92c6b696ce151ff1f9 CHECKSUM(SHA256) upstream package : 4a9bf4ed52db483ed419468e5824d335463b707793c1bf92c6b696ce151ff1f9 Requires -------- spacegl (rpmlib, GLIBC filtered): /usr/bin/bash freeglut glew glfw libGL.so.1()(64bit) libGLEW.so.2.2()(64bit) libGLU.so.1()(64bit) libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libglfw.so.3()(64bit) libglut.so.3()(64bit) libgomp.so.1()(64bit) libgomp.so.1(GOMP_1.0)(64bit) libgomp.so.1(GOMP_4.0)(64bit) libgomp.so.1(GOMP_4.5)(64bit) libgomp.so.1(OMP_1.0)(64bit) libm.so.6()(64bit) libncurses.so.6()(64bit) libtinfo.so.6()(64bit) libvulkan.so.1()(64bit) mesa-libGL mesa-libGLU openssl rtld(GNU_HASH) spacegl-data vulkan-loader spacegl-data (rpmlib, GLIBC filtered): spacegl Provides -------- spacegl: application() application(spacegl.desktop) spacegl spacegl(x86-64) spacegl-data: spacegl-data Generated by fedora-review 0.11.0 (05c5b26) last change: 2025-11-29 Command line :/usr/bin/fedora-review -b 2437502 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, C/C++, Generic Disabled plugins: fonts, Java, Ocaml, PHP, SugarActivity, Python, Haskell, R, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2437502 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202437502%23c116 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
