https://bugzilla.redhat.com/show_bug.cgi?id=2437502
--- Comment #117 from Nicola Taibi <[email protected]> --- Hi Fabio, Thank you very much for your detailed mock review! I have updated the package to address all the issues you identified. Here is a summary of the changes: Spec Cleanup: Removed the duplicated BuildRequires: gcc and stripped all explicit library Requires, allowing RPM to generate them automatically. Modern Macros: Switched to %autorelease and %autochangelog to comply with current Fedora packaging standards. Language: Translated all remaining Italian comments in the spec file to English. Build & Install: Removed the unnecessary make clean from the %build section. Replaced cp with install -p in the %install section to properly set file permissions and preserve timestamps. CLI Nature & Desktop File: As spacegl is a command-line client-server application, I have removed the .desktop file and the desktop-file-utils dependency. Helper Scripts: The run_server.sh and run_client.sh scripts mentioned in the README are now correctly installed as spacegl-server and spacegl-client in %{_bindir}. Legal: Removed the legacy Copyright tag from the spec header and ensured the License field uses the correct SPDX expression. Updated Files: Spec URL: https://download.copr.fedorainfracloud.org/results/ntaibi/space-gl/fedora-43-x86_64/10251609-spacegl/spacegl.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ntaibi/space-gl/fedora-43-x86_64/10251609-spacegl/spacegl-2026.02.09-1.fc43.src.rpm With kind regards, Nick [fedora-review-service-build] -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2437502 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202437502%23c117 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
