https://bugzilla.redhat.com/show_bug.cgi?id=2353415
Phil Wyett <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?([email protected] | |om) --- Comment #24 from Phil Wyett <[email protected]> --- Hi, Sorry, have been busy and distracted. * Package should add to original changelog. This can be found in last successful build at link below. https://kojipkgs.fedoraproject.org//packages/libstroke/0.5.1/47.fc37/src/libstroke-0.5.1-47.fc37.src.rpm * I would remove '%check' section until you are ready. * Line 37: sed -i -e 's|\(#include <math.h>\)|\1\n#include <string.h>|g' %{name}/stroke.c A bit messy. A patch would be better and keep thh4e spec file cleaner. * Usual packaging for 'files' section. %license %doc %others in alphabetical order * Use comments to tell people quickly what is happening - Good practice. - Example # Remove not necessary libtool archive files. rm %{buildroot}%{_libdir}/*.la Regards Phil -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2353415 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202353415%23c24 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
