https://bugzilla.redhat.com/show_bug.cgi?id=2279244
Phil Wyett <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(jonathansteffan@g | |mail.com) --- Comment #38 from Phil Wyett <[email protected]> --- (In reply to Jonathan Steffan from comment #35) > Thanks for picking this up! Now that someone is actually looking at it, I've > put in some more unbundling effort. > > Spec URL: https://jsteffan.fedorapeople.org/imrsv/basalt.spec > SRPM URL: > https://jsteffan.fedorapeople.org/imrsv/basalt-2.0.1-1.20260313git7e8ffb4. > fc43/basalt-2.0.1-1.20260313git7e8ffb4.fc45.src.rpm > > > Changelog: > > - Update to latest commit > - Unbundle as much as I can get to build > - Enable tests, for basalt only > > I have not done a deep dive on what patches need to go to what upstream yet. > We might even just want to keep them downstream and report about them > upstream. What do you think? Hi, I would do the deep dive and offer the patches to upstream and get acceptance or other feedback that can go in the packages spec file. It will help all in the long run. Line 21, can you add an empty line. It will separate the Source0,1,2,3 from other elements and make it easier to read. Bundled: # Best effort commit to version mapping for all thirdparty sources # No upstream versioning Provides: bundled(basalt-headers) # No upstream versioning Provides: bundled(opengv) Provides: bundled(sophus) = 1.22.10 Where possible can you provide upstream links for each of the above where necessary. This will make it easier for folks to jump to these projects for checking while they are not part of Fedora. If you choose to package any of these for Fedora, do let me know and I can pick up the reviews. I will do some further checking, but leave you with the above for now. Regards Phil -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2279244 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202279244%23c38 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
