https://bugzilla.redhat.com/show_bug.cgi?id=2417806
--- Comment #29 from Cristian Le <[email protected]> --- > > Hi Andreas, a quick note about Fedora review process, please continue to use > > the format with `spec` and `srpm` as you did in the first few comments. That > > triggers the Fedora review bot to submit its own copr builds including the > > review.txt. > > Ah! Thanks for the hint! Now it hopefully works again. Lol, I meant more explicitly the format > Spec URL: ... > SRPM URL: ... there is a bit of freedom in the format, but I have not dig into the explicit format. And clearly @[email protected] clearly did some black magic in there also :). > Those were mentioned by the author Wolfgang Friebel as "nice to have" for > most users. I can change that if desired. Yes please do. Fedora has different $OPINIONS ;). It does raise the question, are all of those required in the tests also :-? > %{bindir} is /usr/libexec/lesspipe atm. This is the reason I put the > directory into the rpm. I want this directory to be removed in case the rpm > is uninstalled. Ah, I did not notice that it is `%{bindir}` and not `%{_bindir}`. Yes it is correct then. But please use a different name to avoid this confusion, particularly avoid pre-defined path macros [1]. Something like `%{exec_dir}` or `%{lesspipe_exec_dir}` is available. > https://github.com/wofr06/lesspipe/archive/refs/tags/v%{version}.tar.gz right? Yes. [1]: https://docs.fedoraproject.org/en-US/packaging-guidelines/RPMMacros/#macros_installation -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2417806 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202417806%23c29 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
