https://bugzilla.redhat.com/show_bug.cgi?id=2417806
--- Comment #24 from Cristian Le <[email protected]> --- Hi Andreas, a quick note about Fedora review process, please continue to use the format with `spec` and `srpm` as you did in the first few comments. That triggers the Fedora review bot to submit its own copr builds including the review.txt. Will leave the proper review for Pter since he seems to have better grasp of the package. Just noting some generic package review points: - Please add some comments on why some of the non-obvious dependencies including weak ones are being added. bat, pandoc, and libreoffice are very weird to be on that list - Similarly would be good for the BuildRequires with maybe some hints on where they were found - Heredoc files in the spec file can be quite bug prone. I would recommend a separate source file and using a `sed` to expand the macros instead - `%dir %{bindir}` is unnecessary, that would always be owned by something at the very core of the system. Generally if a hard dependency owns the directories already, co-owning the folder does not do anything for you - And the inverse issue with `%{bash_completion}` should be more explicitly a `%dir` (to avoid any surprises that a file became a directory and vice-versa) or packaging the files in it more explicitly - Using the git archives is generally preferred. You know the libxz fiasco and all that right? - For the GPL-2.0-only license, have you confirmed with upstream that that is their intent? Usually it is not clear from the license text alone if that is the case - Licensecheck for this would be fun. See this gem [1] in the vimcolor script [1]: https://github.com/wofr06/lesspipe/blob/f64d679cae63e86563802363a671cea14493d2c0/vimcolor#L12-L13 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2417806 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202417806%23c24 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
