https://bugzilla.redhat.com/show_bug.cgi?id=2445182
Dominik 'Rathann' Mierzejewski <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #5 from Dominik 'Rathann' Mierzejewski <[email protected]> --- (In reply to fedora from comment #4) [...] > > Also, setting the file mode is most likely not needed. Executables get 0755 > > by default. > > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_permissions > > It looks like not setting file modes doesn't work, at least according to > lint: > > moosefs-client.x86_64: W: non-executable-in-bin /usr/bin/mfsarchive 644 > moosefs-client.x86_64: W: non-executable-in-bin /usr/bin/mfsbdev 644 > moosefs-client.x86_64: W: non-executable-in-bin /usr/bin/mfscopygoal 644 > moosefs-client.x86_64: W: non-executable-in-bin /usr/bin/mfsdiagtools 644 > moosefs-client.x86_64: W: non-executable-in-bin /usr/bin/mfseattr 644 > moosefs-client.x86_64: W: non-executable-in-bin /usr/bin/mfsfacl 644 > moosefs-client.x86_64: W: non-executable-in-bin /usr/bin/mfsgetgoal 644 > moosefs-client.x86_64: W: non-executable-in-bin /usr/bin/mfsmount 644 > moosefs-client.x86_64: W: non-executable-in-bin /usr/bin/mfspatadmin 644 > moosefs-client.x86_64: W: non-executable-in-bin /usr/bin/mfsquota 644 > [... and so on] > > So I'm leaving it there. It works if you remove the %defattr stanza as well. > Should I close this request and open a new one later or just let it > hang for now and upload new versions of everything when I have them ready > (hopefully next week)? Keep this open and hang on for now, there's no rush. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2445182 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202445182%23c5 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
