https://bugzilla.redhat.com/show_bug.cgi?id=2445182
Artur Frenszek-Iwicki <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #3 from Artur Frenszek-Iwicki <[email protected]> --- > Thank you, I updated my initial post. That's still a bad link, as it goes to a syntax-highlighted HTML rendition of the spec. Please use "raw file" links. > # Turn off debug packages > %global _enable_debug_package 0 > %global debug_package %{nil} Debuginfo packages are required, unless the information contained in them isn't very useful. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_debuginfo_packages > Group: System Environment/Daemons > BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) No longer used in Fedora. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections > make %{?_smp_mflags} You may want to use %make_build instead, which handles smp flags for you and enables verbose mode. > %install > rm -rf $RPM_BUILD_ROOT Don't. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections > make install \ > DESTDIR=$RPM_BUILD_ROOT You may want to use %make_install instead, which handles DESTDIR for you. > %files master > [...] > %attr(755,root,root) %{_sbindir}/mfsmaster You should probably use %{_bindir} here, since /sbin is now merged into /bin since Fedora 42. https://fedoraproject.org/wiki/Changes/Unify_bin_and_sbin Also, setting the file mode is most likely not needed. Executables get 0755 by default. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_permissions > # %%attr(755,root,root) %%{_sbindir}/mfsbdev - moved to EXTRA_FILES > /sbin/mount.moosefs This one file uses a literal path instead of the %{_bindir} macro. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2445182 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202445182%23c3 -- _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://forge.fedoraproject.org/infra/tickets/issues/new
