https://bugzilla.redhat.com/show_bug.cgi?id=2086484



--- Comment #17 from Carl George 🤠 <[email protected]> ---
> I've added: `%{_datadir}` to the `%files` section to cover them.

This should be %{_datadir}/neomutt.  Packages shouldn't duplicate directory
ownership with the filesystem package [0].

-%{_datadir}
+%{_datadir}/neomutt

> I've added a patch: neomutt-fedora_colors.patch

This patch creates a single file, which is later read with cat and written to a
file in the buildroot.  You can just have that file as an additional source,
then put it into place during %install.

+# Fedora color scheme
+Source1: fedora_colors.rc

-# Fedora color scheme
-Patch3: neomutt-fedora_colors.patch

-%patch3 -p1 -b .fedora_colors

-cat contrib/fedora_colors.rc >> %{buildroot}%{_sysconfdir}/neomuttrc
+install -D -p -m 0644 %{SOURCE1} %{buildroot}%{_sysconfdir}/neomuttrc

One more thing to be aware of, the built package is getting an automatic
dependency on /usr/bin/python3 due to the shebang lines of executable files in
%{_datadir}/neomutt (account-command/macos-keychain/keychain.py and
oauth2/mutt_oauth2.py).  If you want to avoid that dependency, chmod those
files during %install to make them not executable.

[0]
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_file_and_directory_ownership


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2086484
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to