> On Aug. 26, 2011, 6:05 a.m., Vadim ProductEngine wrote:
> > indra/newview/lltoastnotifypanel.cpp, line 339
> > <http://codereview.secondlife.com/r/449/diff/2/?file=6987#file6987line339>
> >
> >     The surrounding code looks quite messy (not your fault, I know), so 
> > please make more comments to the code you add.

Looking over this mathematical mess I found that ignore_btn_hoffset was a 
leftover from when I was developing this change and was no longer needed.

I have added one comment.


> On Aug. 26, 2011, 6:05 a.m., Vadim ProductEngine wrote:
> > indra/newview/lltoastnotifypanel.cpp, lines 359-369
> > <http://codereview.secondlife.com/r/449/diff/2/?file=6987#file6987line359>
> >
> >     I didn't go through the calculations, but the Mute button is visually 
> > bigger than the Ignore button. Is it intentional?

Yes the block button is larger than the ignore button because:
1) It is the same size as is found in other instances in the UI where it 
appears.
2) I did not know if making it smaller would affect the width needed for 
language translations.


> On Aug. 26, 2011, 6:05 a.m., Vadim ProductEngine wrote:
> > indra/newview/llviewermessage.cpp, lines 6556-6559
> > <http://codereview.secondlife.com/r/449/diff/2/?file=6988#file6988line6556>
> >
> >     It's a hack to update the Block List panel from here.
> >     The panel should be an observer of the mute list, or something like 
> > that, i.e. update itself automatically.

This exact same call is used in 6 other places in the code.  It forces the 
sidebar open and highlights the newly Blocked item as feedback to the user that 
their Block click has had some effect, so I think having this call is correct.


> On Aug. 26, 2011, 6:05 a.m., Vadim ProductEngine wrote:
> > indra/newview/skins/default/xui/en/notifications.xml, lines 6279-6282
> > <http://codereview.secondlife.com/r/449/diff/2/?file=6989#file6989line6279>
> >
> >     I suppose these changes must be also made to the "ScriptDialog" 
> > notification template.

Good catch!


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://codereview.secondlife.com/r/449/#review993
-----------------------------------------------------------


On Aug. 23, 2011, 1:41 p.m., Jonathan Yap wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://codereview.secondlife.com/r/449/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2011, 1:41 p.m.)
> 
> 
> Review request for Viewer.
> 
> 
> Summary
> -------
> 
> Add a block button to popups from llDialog calls.  Clicking on the Block 
> button adds the object to the block list.  The type of block is Object.  
> Changing the object's name does not defeat this block as the block entry is 
> stored as a UUID.
> 
> Note: The object's name in the block list does not change if the object is 
> renamed, though the block does work.  This may need to be addressed in a 
> separate SVC jira once this change is incorporated into viewer-development.
> 
> 
> This addresses bug STORM-1567.
>     http://jira.secondlife.com/browse/STORM-1567
> 
> 
> Diffs
> -----
> 
>   doc/contributions.txt 4ebbd04efd93 
>   indra/newview/lltoastnotifypanel.cpp 4ebbd04efd93 
>   indra/newview/llviewermessage.cpp 4ebbd04efd93 
>   indra/newview/skins/default/xui/en/notifications.xml 4ebbd04efd93 
> 
> Diff: http://codereview.secondlife.com/r/449/diff
> 
> 
> Testing
> -------
> 
> Tested per Test Plan jira entry.
> 
> 
> Thanks,
> 
> Jonathan
> 
>

_______________________________________________
Policies and (un)subscribe information available here:
http://wiki.secondlife.com/wiki/OpenSource-Dev
Please read the policies before posting to keep unmoderated posting privileges

Reply via email to