----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/424/#review970 -----------------------------------------------------------
We picked the precision values for those spinners based on what would survive the roundtrip via our precision-limited object update packets. Adding more precision will possibly result in confusion when the values don't respond the way you expect them to. This is particularly a problem for rotation...position and scale could probably survive another decimal point...I haven't done the math. - Richard On July 29, 2011, 4:40 p.m., Kadah Coba wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/424/ > ----------------------------------------------------------- > > (Updated July 29, 2011, 4:40 p.m.) > > > Review request for Viewer. > > > Summary > ------- > > Adds 2 features: > > Adds the ability to use modifier keys to change the defined increment on > LLSpinCtrl. > Alt: increment x10 > Ctrl: increment x0.1 > Shift: increment x0.01 > > Adds extra decimal places to position, size, and rotation on build floater. > Also changes LLPanelObject::sendPosition and LLPanelObject::sendScale to set > smaller changes in the associated values, no change was needed for > LLPanelObject::sendRotation. There should be no ill effects from this, > changes are still only sent to sim on button release. > > https://bitbucket.org/Kadah_Coba/storm-56 > > > This addresses bug STORM-56. > http://jira.secondlife.com/browse/STORM-56 > > > Diffs > ----- > > indra/llui/llspinctrl.cpp UNKNOWN > indra/newview/llpanelobject.cpp UNKNOWN > indra/newview/skins/default/xui/en/floater_tools.xml UNKNOWN > > Diff: http://codereview.secondlife.com/r/424/diff > > > Testing > ------- > > Same code has been in use on FS beta for some time. I have built and tested > this myself on v-d. > > > Thanks, > > Kadah > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
