On Mon, 30 Mar 2026 15:51:58 GMT, Ambarish Rapte <[email protected]> wrote:
>> - Create implementation of protocol; >> - Wire new implementation to TEXT_AREA and TEXT_FIELD roles; >> - Add supporting method to store and request java side role; >> - Add method to retrieve node attribute for the specified parameter; > > modules/javafx.graphics/src/main/native-glass/mac/a11y/JFXNavigableTextAccessibility.m > line 101: > >> 99: } >> 100: >> 101: - (NSRect)accessibilityFrameForRange:(NSRange)range > > May be a separate block for these 4 methods and add a comment to mention that > these methods are inherited from `NSAccessibilityNavigableStaticText`. Not sure i understand - all methods except the basic ones such as value, role/subrole and such are implementation of the NSAccessibilityNavigableStaticText protocol. I can add corresponding commentary in the beginning of the implementation but it's not only these four methods - it is most of the class. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2130#discussion_r3012002044
