On Fri, 27 Mar 2026 23:18:02 GMT, Alexander Zuev <[email protected]> wrote:
> - Create implementation of protocol;
> - Wire new implementation to TEXT_AREA and TEXT_FIELD roles;
> - Add supporting method to store and request java side role;
> - Add method to retrieve node attribute for the specified parameter;
Providing a few minor suggestions..
modules/javafx.graphics/src/main/native-glass/mac/a11y/AccessibleBase.m line
117:
> 115: }
> 116:
> 117: - (void)setJavaRole:(NSString *)newRole
Method declaration is not included in `AccessibleBase.h`
modules/javafx.graphics/src/main/native-glass/mac/a11y/JFXNavigableTextAccessibility.m
line 78:
> 76: {
> 77: return [self requestNodeAttribute:@"AXTitle"];
> 78: }
This method is inherited from `Accessible`, body is same and not overriding
does not throw an error. Can be removed.
modules/javafx.graphics/src/main/native-glass/mac/a11y/JFXNavigableTextAccessibility.m
line 101:
> 99: }
> 100:
> 101: - (NSRect)accessibilityFrameForRange:(NSRange)range
May be a separate block for these 4 methods and add a comment to mention that
these methods are inherited from `NSAccessibilityNavigableStaticText`.
modules/javafx.graphics/src/main/native-glass/mac/a11y/JFXNavigableTextAccessibility.m
line 127:
> 125: {
> 126: return nil; //For now. Once we have multiselection text area we
> might revisit it.
> 127: }
Removing these two methods does not throw any error. so, looks like overriding
is not mandatory.
-------------
Changes requested by arapte (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/2130#pullrequestreview-4031450680
PR Review Comment: https://git.openjdk.org/jfx/pull/2130#discussion_r3010564688
PR Review Comment: https://git.openjdk.org/jfx/pull/2130#discussion_r3010655145
PR Review Comment: https://git.openjdk.org/jfx/pull/2130#discussion_r3010691302
PR Review Comment: https://git.openjdk.org/jfx/pull/2130#discussion_r3010667210
