On Mon, 23 Mar 2026 20:06:58 GMT, Michael Strauß <[email protected]> wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add flag to disable portal file chooser > > modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp line 289: > >> 287: Size size = view_size.get(); >> 288: >> 289: move_resize(loc.x, loc.y, true, true, size.width, size.height); > > `WindowContext::window_location` is initialized to (-1, -1) in the class > declaration. However, the first map treats this sentinel value as an actual > location and calls `move_resize(-1, -1, ...)`. Is this intended? > > Same question for `view_size`, which is initialized to (-1, -1). Fixed. `move_resize(loc.x, loc.y, (loc.x >= 0), (loc.y >= 0), size.width, size.height);` For view_size, it will have valid values when mapped, but previously -1 was being sent before mapping. I added a guard to prevent that. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1789#discussion_r2998015121
