On Mon, 23 Mar 2026 20:22:47 GMT, Michael Strauß <[email protected]> wrote:
>> Thiago Milczarek Sayao has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add flag to disable portal file chooser > > modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp line 210: > >> 208: // is being iterated here) but also prevents >> gtk_window_set_transient_for from >> 209: // being called - this causes the crash on gnome. >> 210: gtk_window_set_transient_for((*it)->get_gtk_window(), NULL); > > Is `gtk_window_set_transient_for(..., nullptr)` no longer required? I see > that you've also removed it from `WindowContext::remove_child()`, but the > relation is still set in `WindowContext::add_child()`. Yes, that's correct — this is no longer required because it now relies on a GdkWindow instead of a GtkWindow. The original requirement was introduced as a safeguard against crashes caused by the additional lifecycle and state management involved in GtkWindow. Since GdkWindow operates at a lower level and does not carry those higher-level GTK responsibilities, those issues no longer apply. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1789#discussion_r2993504215
