On Mon, 23 Mar 2026 13:56:23 GMT, Marius Hanl <[email protected]> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 19 additional >> commits since the last revision: >> >> - Merge branch 'master' into 8353599.menu.factory >> - Merge branch 'master' into 8353599.menu.factory >> - 2026 >> - Merge branch 'master' into 8353599.menu.factory >> - Merge branch 'master' into 8353599.menu.factory >> - Merge branch 'master' into 8353599.menu.factory >> - Merge branch 'master' into 8353599.menu.factory >> - Merge branch 'master' into 8353599.menu.factory >> - Merge remote-tracking branch 'origin/master' into 8353599.menu.factory >> - Merge branch 'master' into 8353599.menu.factory >> - ... and 9 more: https://git.openjdk.org/jfx/compare/bc840c98...534b81ee > > modules/javafx.controls/src/main/java/javafx/scene/control/skin/TabPaneSkin.java > line 2024: > >> 2022: public void dispose() { >> 2023: textProperty().unbind(); >> 2024: disableProperty().unbind(); > > This seems unrelated. related: I've replaced `weakDisableListener` L1967 with binding. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1773#discussion_r2983320736
