On Mon, 23 Mar 2026 14:02:40 GMT, Marius Hanl <[email protected]> wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 21 additional >> commits since the last revision: >> >> - review comments >> - Merge branch 'master' into 8353599.menu.factory >> - Merge branch 'master' into 8353599.menu.factory >> - Merge branch 'master' into 8353599.menu.factory >> - 2026 >> - Merge branch 'master' into 8353599.menu.factory >> - Merge branch 'master' into 8353599.menu.factory >> - Merge branch 'master' into 8353599.menu.factory >> - Merge branch 'master' into 8353599.menu.factory >> - Merge branch 'master' into 8353599.menu.factory >> - ... and 11 more: https://git.openjdk.org/jfx/compare/5df34ff0...3578ed25 > > modules/javafx.controls/src/main/java/javafx/scene/control/skin/TabPaneSkin.java > line 1512: > >> 1510: >> 1511: getProperties().put(Tab.class, tab); >> 1512: getProperties().put(ContextMenu.class, >> tab.getContextMenu()); > > Seems unrelated - does that have any consequences? the popup logic has been moved to L1985 ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1773#discussion_r2984525729
