On Mon, 23 Mar 2026 23:28:24 GMT, Marius Hanl <[email protected]> wrote:
>>> I could be mistaken, but it tests the TextField as a part of a larger >>> construct. The test _might_ be faulty, but that's another topic. >> >> Yeah it tried, but failed. As I said. >> Lets break it down. This is the very questionable fix: >> https://github.com/openjdk/jfx/blob/0500668190ca16772f89b9a07987bc9df4c56fdc/modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java#L475-L498 >> >> Conditions: >> - `VirtualFlow` must be in a scene graph -> not fulfilled >> - Cells must be a part of the `VirtualFlow` -> not fulfilled (created with >> new) >> - `TextField` must be a part of the Cell -> not fulfilled, it will be alone >> in the `Stage`, without its parent cell >> >> I will now have a look if it can be easily rewritten so those conidtions are >> true. But I will not waste to much time, as the fix is also very >> questionable as well. Otherwise, I will restore what was there before, no >> changes. > > This is the test coverage: > <img width="557" height="37" alt="image" > src="https://github.com/user-attachments/assets/f93a5b0e-f4af-4d8b-8b92-133726a5606f"; > /> > <img width="1064" height="811" alt="image" > src="https://github.com/user-attachments/assets/34778203-2564-4c96-84cf-1e545b4c6e02"; > /> test improved, works the same, but with a real stage setup. All three Conditions above are now fulfilled. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2124#discussion_r2978200335
