On Mon, 23 Mar 2026 21:05:03 GMT, Marius Hanl <[email protected]> wrote:
>> I am a bit confused - you reverted the fix for >> https://bugs.openjdk.org/browse/JDK-8119995 ? >> >> I am a bit reluctant to remove the test, can we keep it? > > Yes, I reverted the fix and this test is still green. > Because as I said, it does not test the table at all. The table (and > therefore `VirtualFlow`, which was adjusted) is never in the scene graph. > > We just spin up: > > Group > └ TextField > > And do 2 right click in the `TextField`. No table attached, nothing that is > really tested here. To put it mildly, this test does absolutely nothing. > > If you want me to keep it, I will write: > `stageLoader = new StageLoader(textField);` > and we have the same behavior and a green test that tests nothing. unless you want to fix the test, "let's minimize the changes". there is a non-zero probability of someone breaking the code in some other way and this test catching it, right? ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2124#discussion_r2977697961
