On Sat, 14 Mar 2026 02:13:25 GMT, Christopher Schnick <[email protected]>
wrote:
>> This PR replaces various catch blocks for NPEs by proper null checks. It
>> looks like a lot but most of the binding changes are just variants of the
>> same approach. The test cases have been adapted to not check for NPEs
>> anymore.
>>
>> The PrismFontFactory change to a RuntimeException was made because I don't
>> see how the try block can throw an NPE.
>
> Christopher Schnick has updated the pull request with a new target base due
> to a merge or a rebase. The pull request now contains nine commits:
>
> - Address review comments
> - Add test clarifying generics handling
> - Fix failing tests
> - Improve log messages and fix more catch blocks in SelectBinding
> - Fix visibility
> - Fixes
> - Fixes
> - More fixes
> - Handle exceptions better
Two minor comments, looks good otherwise
modules/javafx.base/src/main/java/javafx/beans/binding/Bindings.java line 7514:
> 7512: protected V computeValue() {
> 7513: final Object currentKey = key.getValue();
> 7514: final V val = getMapValue(op, currentKey);
Can also be returned directly
modules/javafx.base/src/test/java/test/com/sun/javafx/binding/SelectBindingTest.java
line 49:
> 47: import javafx.collections.ObservableList;
> 48: import org.junit.jupiter.api.AfterEach;
> 49: import org.junit.jupiter.api.Assertions;
This import is now unused
-------------
Marked as reviewed by mhanl (Committer).
PR Review: https://git.openjdk.org/jfx/pull/2032#pullrequestreview-3962684731
PR Review Comment: https://git.openjdk.org/jfx/pull/2032#discussion_r2948568411
PR Review Comment: https://git.openjdk.org/jfx/pull/2032#discussion_r2948590919
