On Sat, 14 Mar 2026 02:13:25 GMT, Christopher Schnick <[email protected]> wrote:
>> This PR replaces various catch blocks for NPEs by proper null checks. It >> looks like a lot but most of the binding changes are just variants of the >> same approach. The test cases have been adapted to not check for NPEs >> anymore. >> >> The PrismFontFactory change to a RuntimeException was made because I don't >> see how the try block can throw an NPE. > > Christopher Schnick has updated the pull request with a new target base due > to a merge or a rebase. The pull request now contains nine commits: > > - Address review comments > - Add test clarifying generics handling > - Fix failing tests > - Improve log messages and fix more catch blocks in SelectBinding > - Fix visibility > - Fixes > - Fixes > - More fixes > - Handle exceptions better Marked as reviewed by angorya (Reviewer). ------------- PR Review: https://git.openjdk.org/jfx/pull/2032#pullrequestreview-3957295573
