On Thu, 12 Mar 2026 22:34:25 GMT, Marius Hanl <[email protected]> wrote:
>> As also discussed back then in the mailing list, there are weird issues
>> around gaining focus when a `Control` is not focus traversable but got a
>> click event.
>>
>> - Some Controls do not call `requestFocus()` when they are not focus
>> traversable and receive a mouse click
>> - It is very inconsistent which Controls do it and which do not. Sometimes,
>> just a part of a `Control` will request focus, while another one will not
>> - Manually calling `requestFocus()` always works
>>
>> It seems like there is a misconception between beeing not focus traversable
>> and not requesting focus. The focus traversable property should only affect
>> keyboard navigation really. A mouse click should always request a focus.
>>
>> Check the Ticket for a reproducer with all `Control`s and a short list which
>> Controls do not behave (and which do).
>>
>> This PR removes the pattern that was wrongly used in some `Control`s.
>> From:
>>
>> if (getNode().isFocusTraversable()) {
>> getNode().requestFocus();
>> }
>>
>> To:
>>
>> getNode().requestFocus();
>
> Marius Hanl has updated the pull request incrementally with one additional
> commit since the last revision:
>
> revert change in Node
This exposed a problem inside `VirtualFlow`. This will very likely need a
localized fix there. In any case, the concept of this PR can still be reviewed
already.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/2106#issuecomment-4050789145
