On Thu, 12 Mar 2026 22:14:51 GMT, Marius Hanl <[email protected]> wrote:

> As also discussed back then in the mailing list, there are weird issues 
> around gaining focus when a `Control` is not focus traversable but got a 
> click event.
> 
> - Some Controls do not call `requestFocus()` when they are not focus 
> traversable and receive a mouse click
> - It is very inconsistent which Controls do it and which do not. Sometimes, 
> just a part of a `Control` will request focus, while another one will not
> - Manually calling `requestFocus()` always works
> 
> It seems like there is a misconception between beeing not focus traversable 
> and not requesting focus. The focus traversable property should only affect 
> keyboard navigation really. A mouse click should always request a focus.
> 
> Check the Ticket for a reproducer with all `Control`s and a short list which 
> Controls do not behave (and which do).
> 
> This PR removes the pattern that was wrongly used in some `Control`s.
> From:
> 
>     if (getNode().isFocusTraversable()) {
>         getNode().requestFocus();
>     }
> 
> To:
> 
>     getNode().requestFocus();

modules/javafx.graphics/src/main/java/javafx/scene/Scene.java line 2418:

> 2416:      * @return boolean indicating whether the scene is quiescent
> 2417:      */
> 2418:     boolean isQuiescent() {

This method was unused.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2106#discussion_r2927692048

Reply via email to