On Friday 21 June 2013 16:12:21 Kai Kang wrote:
> Add strace configure options libaio and acl to enable or disable build
> with them. Then PACKAGECONFIG can be used to handle dependency.
>
> Set "libaio" as a default feature of PACKAGECONFIG.
>...
>
> +PACKAGECONFIG_class-target ?= "libaio"
> +PACKAGECONFIG_class-target += "${@base_contains('DISTRO_FEATURES', 'acl',
> 'acl', '', d)}"
I realise this has already been merged, but I think there are a couple of issues
with the above. Firstly, for consistency, I think the first option should be
called "aio" and not "libaio". Secondly, although this seems to work the use
of overrides, += and ?= together is a little bit confusing. Perhaps the
following
would be a bit clearer:
PACKAGECONFIG_class-target ?= "aio \
${@base_contains('DISTRO_FEATURES', 'acl',
'acl', '', d)}"
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core
