aacid added a comment.
I don't really have the time to spend print stuff to check if this does what it says it does, so i'm just doing code review from the pure formal way. INLINE COMMENTS > document.cpp:83 > #include "pagecontroller_p.h" > +#include "printoptionswidget.h" > #include "scripter.h" i guess you don't need this include? > printoptionswidget.h:46 > + > + virtual bool ignorePrintMargins() const override; > + i think best practices say to not include virtual when it's an override REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D10974 To: michaelweghorn, #okular Cc: fvogt, rkflx, arthurpeters, ltoscano, okular-devel, aacid, ngraham, tfella, darcyshen
