aacid added inline comments.
INLINE COMMENTS
> document.h:728
> */
> - QWidget* printConfigurationWidget() const;
> + PrintOptionsWidget* printConfigurationWidget() const;
>
this is binary incompatible :/
We could just let it be a QWidget but document it has to be a PrintOptionsWidge
subclass, and then on the user do a dynamic_cast and complain if it is not a
PrintOptionsWidget, but maybe we can just say meh and break the BC.
> generator_pdf.cpp:141
>
> + virtual bool ignorePrintMargins() const override {
> + return scaleMode() == FitToPage;
remove the virtual
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D10974
To: michaelweghorn, #okular
Cc: fvogt, rkflx, arthurpeters, ltoscano, okular-devel, aacid, ngraham,
darcyshen
