On Sun, May 20, 2012 at 6:08 AM, Travis Oliphant <tra...@continuum.io> wrote: > Wow, Nathaniel. This looks like a nice piece of tedious work.
Honestly, it only took a few hours -- M-x grep is awesome. Would still have been better if it'd been separated in the first place, but so it goes. > I have not reviewed it in detail, but in general I would be very supportive > of your plan to commit this to master, make a 1.7 release (without the > ReduceWrapper) function and then work on the masked array / ndarray > separation plan for 1.8 > > Of course, first I would want to hear from Mark, to hear his comments about > what was removed. Definitely. I'm pretty sure I didn't accidentally sweep up anything else in my net besides what it says in the commit messages (simply because it's hard to do that when all you're doing is grepping for HASMASKNA and friends), but he knows this code better than I do. NB for anyone who may have pulled, I did just rebase this (and push --force it) to fix a trivial issue (I forgot to remove the signature for PyArray_CountNonZero when I removed the function itself). So you'll want to throw away any local branches if you have them. - N _______________________________________________ NumPy-Discussion mailing list NumPy-Discussion@scipy.org http://mail.scipy.org/mailman/listinfo/numpy-discussion
