stoty commented on code in PR #2239: URL: https://github.com/apache/zookeeper/pull/2239#discussion_r2014827959
########## zookeeper-docs/src/main/resources/markdown/zookeeperAdmin.md: ########## @@ -1738,7 +1738,9 @@ and [SASL authentication for ZooKeeper](https://cwiki.apache.org/confluence/disp (Java system properties: **zookeeper.ssl.ciphersuites** and **zookeeper.ssl.quorum.ciphersuites**) **New in 3.5.5:** Specifies the enabled cipher suites to be used in client and quorum TLS negotiation. - Default: Enabled cipher suites depend on the Java runtime version being used. + Default: None, the JVM defaults are used (3.10.0+), + Enabled cipher suites are hard coded, with the ordering dependent on whether Java 8, or Java 9+ is used. + For Java 8 the list begins with the TLSv1.2 CBC ciphers, while for Java 9+ it begins with the TLSv1.2 CBM ciphers (3.5.5-3.9.x). Review Comment: The format of this list doesn't really allow for long readable explanations. We could add it in a separate section maybe ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
