stoty commented on code in PR #2239:
URL: https://github.com/apache/zookeeper/pull/2239#discussion_r2013634870
##########
zookeeper-server/src/main/java/org/apache/zookeeper/common/ClientX509Util.java:
##########
@@ -80,7 +80,10 @@ public SslContext createNettySslContextForClient(ZKConfig
config)
}
sslContextBuilder.enableOcsp(config.getBoolean(getSslOcspEnabledProperty()));
- sslContextBuilder.protocols(getEnabledProtocols(config));
+ String[] enabledProtocols = getEnabledProtocols(config);
Review Comment:
You're right, it's not necessary.
However, I think that the if improves readability by handling the null value
explicitly, and showing that we leave the defaults in this case.
I can remove it if you prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
