ctubbsii commented on code in PR #2224: URL: https://github.com/apache/zookeeper/pull/2224#discussion_r1970540461
########## tools/sonar/code-coverage.sh: ########## @@ -1,4 +1,5 @@ -#!/usr/bin/env bash +#! /usr/bin/env bash Review Comment: Short answer: it's not necessary, but it's helpful. It's optional, but it improves readability, and in fact a space was used in the original example for how to use them in an email from Dennis Ritchie discussing the support for it added to the Unix kernel. Additionally, historically, there have been various rumors that a space was required on some versions of the kernel... but that appears to have just been rumors. Nevertheless, some people's beliefs about the space being important persists. Having the space there avoids unnecessary distractions and complaints from those people who are probably wrong, but might bring it up (see https://en.wikipedia.org/wiki/Shebang_(Unix)#History). If you have to standardize on something, you might as well standardize on the variant that is going to cause less conflict, if all else is equal. So, I think the main reasons it is helpful to have the space are: 1. improved readability and 2. avoiding distracting complaints from people who still believe the historical rumors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
