ctubbsii commented on PR #2224: URL: https://github.com/apache/zookeeper/pull/2224#issuecomment-2673153113
This is draft because I'm still fixing the scripts outside the bin directory, and also adding CI checks for shfmt and shellcheck, to prevent regressions and further bugs. I did find an issue that I am not yet sure how to resolve, at https://github.com/apache/zookeeper/blob/a39c8d8ab68aa4a1469855795d9a241a74f963f1/zookeeper-server/src/test/resources/test-github-pr.sh#L100 That line is broken... you can't have nested variables like that. I'm wondering if that test-github-pr.sh script should just be deleted (and maybe some of the other files, too, like test-patch.sh) since GitHub Actions and JIRA exist. Those scripts don't really seem to add much value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
