slachiewicz opened a new pull request, #3973: URL: https://github.com/apache/thrift/pull/3973
Adds `TConfiguration.cpp` with out-of-line definitions of `DEFAULT_MAX_MESSAGE_SIZE`, `DEFAULT_MAX_FRAME_SIZE` and `DEFAULT_RECURSION_DEPTH`, so binding one to a reference links before C++17. The new test takes each constant's address through a `volatile` pointer, which needs the definitions at any optimisation level; on master it fails to link even in a Release build. Verified: Ubuntu 24.04 arm64, GCC 13, C++11 — Debug build of UnitTests links and passes 141/141 (fails to link on master); TTransportFactoryConfigTest 11/11 in Debug and Release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
