Jens-G commented on PR #3836:
URL: https://github.com/apache/thrift/pull/3836#issuecomment-5618103129

   @brad0 — a heads-up, since this touches what #3737 just fixed. This PR takes 
`AI_V4MAPPED` out of the C++ library altogether (Android's bionic rejects the 
flag at runtime, see the review above), so nothing uses the symbol any more, 
and b7b79f7bb removes the OpenBSD fallback for it from `configure.ac`, 
`build/cmake/ConfigureChecks.cmake` and `build/cmake/config.h.in` again. On 
OpenBSD the flags passed to `getaddrinfo()` stay what they were with #3737, 
where `AI_V4MAPPED` was defined as `0`.
   
   I can't build on OpenBSD here — could you check that this branch still 
builds for you, with CMake and/or autotools?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to