Jens-G commented on PR #3836: URL: https://github.com/apache/thrift/pull/3836#issuecomment-5616756599
Re the review above (https://github.com/apache/thrift/pull/3836#issuecomment-5616331054): confirmed, and fixed in 0b4335fd370d4483f343ea57e301af5d96c51fb1. Both server sockets now resolve with exactly `TSocket::open()`'s flags — `AI_PASSIVE|AI_ADDRCONFIG`, then `AI_PASSIVE` — so `AI_V4MAPPED` is out of both attempts. On glibc that changes nothing for the `AF_UNSPEC` query: both flag sets give the same addresses for `localhost`, `::1`, `127.0.0.1` and the wildcard. `AddressResolutionHelper`'s default flags carried the same `AI_V4MAPPED` and now default to `AI_ADDRCONFIG` alone, and the comment in `TServerExceptionTest.cpp` that still described the old server flags is reworded. Verified by emulating bionic's check with an `LD_PRELOAD` `getaddrinfo()` that returns `EAI_BADFLAGS` for any flag outside its `AI_MASK`: at 00132b117, `TNonblockingServerTest` (6 of 7 cases) and `TServerExceptionTest` (3 cases) fail under it with `Bad value for ai_flags`; with the fix they pass, and so does `TServerSocketTest`. The first commit's message still gives the wrong reason for dropping the `ANDROID` branch ("`AI_V4MAPPED` is ignored for `AF_UNSPEC` queries"); the follow-up's message corrects it, and the PR description is updated to match. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
