Jens-G commented on PR #3650:
URL: https://github.com/apache/thrift/pull/3650#issuecomment-5028631457
### Code review
Found 1 issue:
1. The new empty-body check in `flush` raises on every successful oneway
call. A oneway RPC never gets `write_result` invoked server-side (the generated
`process_XXX` returns immediately for oneway functions), so the server
legitimately answers with HTTP 200 and a zero-length body — exactly the
condition this PR now treats as an error. `test/rb/integration/TestClient.rb`
already skips oneway assertions for the HTTP transport (`omit('oneway behavior
is server-specific over HTTP')`), which is why CI won't catch this.
https://github.com/apache/thrift/blob/4657c2f5781012c68ffb4f95e3c51c4489130bdb/lib/rb/lib/thrift/transport/http_client_transport.rb#L57-L61
https://github.com/apache/thrift/blob/d2001f7444f7540e26ca553ceddad10e31392298/compiler/cpp/src/thrift/generate/t_rb_generator.cc#L1124-L1130
🤖 Generated with [Claude Code](https://claude.ai/code)
<sub>- If this code review was useful, please react with 👍. Otherwise, react
with 👎.</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
