kpumuk commented on code in PR #3650:
URL: https://github.com/apache/thrift/pull/3650#discussion_r3618113722
##########
lib/rb/lib/thrift/transport/http_client_transport.rb:
##########
@@ -55,6 +55,9 @@ def flush
raise TransportException.new(TransportException::UNKNOWN,
"#{self.class.name} Could not connect to #{@url}, HTTP status code
#{resp.code.to_i}") unless (200..299).include?(resp.code.to_i)
data = resp.body
+ if data.nil? || data.empty?
+ raise TransportException.new(TransportException::UNKNOWN,
"#{self.class.name} received an empty response")
Review Comment:
Will wait for https://github.com/apache/thrift/pull/3649 to merge, to re-use
a secure `#to_s`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
