kpumuk commented on code in PR #3649:
URL: https://github.com/apache/thrift/pull/3649#discussion_r3618081960
##########
lib/rb/lib/thrift/transport/http_client_transport.rb:
##########
@@ -62,7 +62,9 @@ def flush
end
def to_s
- "@{self.url}"
+ path = @url.path.to_s
+ path = '/' if path.empty?
+ "#{@url.scheme}(#{@url.host}:#{@url.port}#{path})"
Review Comment:
Added a test, we actually format the host correctly for ipv6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
