Copilot commented on code in PR #3649:
URL: https://github.com/apache/thrift/pull/3649#discussion_r3617947905
##########
lib/rb/lib/thrift/transport/http_client_transport.rb:
##########
@@ -62,7 +62,7 @@ def flush
end
def to_s
- "@{self.url}"
+ "#{@url.scheme}(#{@url.host}:#{@url.port}#{@url.path})"
end
Review Comment:
The non-2xx response error message in `flush` still interpolates `@url`,
which includes userinfo and query parameters (e.g., credentials/tokens). This
undermines the goal of keeping endpoint labels safe for logs/exceptions; use
the transport’s sanitized `to_s` (or equivalent) in the exception message
instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
