Jens-G opened a new pull request, #3624:
URL: https://github.com/apache/thrift/pull/3624
## Summary
Adds a `make dist` job to CI so stale `EXTRA_DIST` references are caught at
merge time instead of only when cutting a release.
**Why now:** preparing the 0.24.0 release surfaced `make dist` breakages
that had sat for months — a removed `Thrift.podspec` (Swift binding removal)
and a moved netstd `THttpServerTransport.cs` — because no GitHub Actions
workflow runs `make dist` (only the legacy `.travis.yml` referenced it). Both
breakages are present on `master` today.
## Changes
1. **Fix the two stale `EXTRA_DIST` references** currently on `master`
(`Makefile.am`, `lib/netstd/Makefile.am`) — a prerequisite for the new job to
be green:
- `Thrift.podspec` was removed with the Swift binding but left in the
top-level `EXTRA_DIST`.
- netstd `THttpServerTransport.cs` was moved into
`Thrift.AspNetCore/Transport/Server/`; `EXTRA_DIST` now points at the
`Transport` directory, matching the existing `Thrift/Transport` entry.
2. **Add `.github/workflows/make-dist.yml`** — runs `bootstrap` → `configure
--disable-libs` → `make dist` on `ubuntu-24.04` for every push/PR, then
verifies the tarball is produced.
`--disable-libs` keeps the job fast and toolchain-independent; `make dist`
still recurses every language directory via `DIST_SUBDIRS`, so all `EXTRA_DIST`
lists are validated regardless of which bindings are enabled.
## Verification
Ran the exact job recipe on a clean `ubuntu:24.04` container with only the
listed `apt` dependencies:
`./bootstrap.sh && ./configure --disable-debug --disable-tests
--disable-libs && make dist` completes and produces a valid
`thrift-0.24.0.tar.gz` (3487 entries). Confirmed `make dist` still recurses and
packages `lib/netstd` even with libs disabled (so a stale ref there would fail
the job).
## Notes
- Companion PR for `release/0.24.0`: #3623. That branch additionally fixes a
separate `configure` Go/Rust version-detection bug. `master` has that bug too,
but this job does not trip it (`--disable-libs` skips the version probes).
Happy to send the `configure` fix for `master` as a follow-up if wanted.
- No JIRA ID in the commit titles yet — add `THRIFT-NNNN:` if you want JIRA
linking.
---
🤖 AI-assisted with Claude Code (Claude Opus 4.8). The human author has
reviewed and tested all changes.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
