Jens-G opened a new pull request, #3623: URL: https://github.com/apache/thrift/pull/3623
## Summary Fixes two independent problems that break the build on `release/0.24.0`, one commit per issue. ### 1. Go/Rust version detection for multi-digit versions (`configure.ac`) — `Client: go,rs` The version-parsing `sed` in `configure` only matched single-digit version components (`[0-9].[0-9].[0-9]`), so modern toolchains such as `go1.25.0` did not match. The raw, unparsed output — a multi-line string containing `/` (from `linux/amd64` and the `go: downloading …` toolchain line triggered by the root `go.mod`'s `go 1.25`) — was stored verbatim in `golang_version` / `rustc_version`. That broke `AX_COMPARE_VERSION`'s internal `sed` (`unterminated 's' command`) and corrupted `config.status`, so `configure` failed while *bootstrapping the dependency-tracking makefile fragments* and produced a malformed `Makefile`. Fix: anchor both expressions to the reported version line and accept multi-digit, multi-component versions → clean `1.25.0` / `1.85.1`. ### 2. Stale `EXTRA_DIST` references breaking `make dist` (`Makefile.am`, `lib/netstd/Makefile.am`) — `Client: netstd` `make dist` aborted with `No rule to make target …, needed by 'distdir-am'`: - `Thrift.podspec` was removed together with the Swift binding but left behind in the top-level `EXTRA_DIST`. - The netstd `THttpServerTransport.cs` was moved into `Thrift.AspNetCore/Transport/Server/`; `EXTRA_DIST` now points at the `Transport` directory, matching the existing `Thrift/Transport` entry. ## Verification `./bootstrap.sh && ./configure && make dist` now completes and produces a valid `thrift-0.24.0.tar.gz`, verified end-to-end on a clean tree (`Thrift.podspec` correctly absent, the netstd source present at its new path). ## Notes - No JIRA ID is in the commit titles yet — add `THRIFT-NNNN:` if you want JIRA linking. - These `make dist` breakages were not caught by CI because no GitHub Actions workflow runs `make dist` (only the legacy `.travis.yml` references it). A separate PR against `master` adds a `make dist` job to prevent recurrence. --- 🤖 AI-assisted with Claude Code (Claude Opus 4.8). The human author has reviewed and tested all changes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
