CJCombrink commented on PR #3332: URL: https://github.com/apache/thrift/pull/3332#issuecomment-4021863674
> Also added UUID format validation in a follow-up commit. The `writeUuid()` method now validates input across all protocols (Binary, Compact, JSON), and `readUuid()` validates in JSON protocol (where UUID arrives as a string). Invalid UUIDs throw `TProtocolException::INVALID_DATA`. I have been thinking about this since on the NodeJS side it does validation when reading values. However I don't think that validation is something that should be happen for every field for every request, I think it adds unnecessary overhead for an application that is correct (that probably does validation outside of the message exchange). Perhaps useful for debugging but not in operation. @Jens-G What is your feeling around this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
