sveneld commented on PR #3332: URL: https://github.com/apache/thrift/pull/3332#issuecomment-4021641570
Thanks for the review! Here's the visual confirmation of wire format compatibility between PHP and C++: ### UUID: `550e8400-e29b-41d4-a716-446655440000` | Implementation | Protocol | Wire bytes (hex) | Length | |---|---|---|---| | **PHP** | Binary | `550e8400e29b41d4a716446655440000` | 16 bytes | | **PHP** | Compact | `550e8400e29b41d4a716446655440000` | 16 bytes | | **C++** | Binary | `550e8400e29b41d4a716446655440000` | 16 bytes | | **C++** | Compact | `550e8400e29b41d4a716446655440000` | 16 bytes | ### Zero UUID: `00000000-0000-0000-0000-000000000000` | Implementation | Wire bytes (hex) | |---|---| | **PHP** | `00000000000000000000000000000000` | Both implementations produce identical 16-byte big-endian wire representation. The UUID hex digits are written directly as bytes in order — no byte swapping, no endianness issues. **Test method:** Built the C++ thrift library and a test program that writes the same UUID via `TBinaryProtocol::writeUUID()` and `TCompactProtocol::writeUUID()`, then compared the raw wire bytes with the PHP output from `TBinaryProtocol::writeUuid()` and `TCompactProtocol::writeUuid()`. Both were run inside the same ubuntu-noble Docker container. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
