fishy commented on code in PR #3164:
URL: https://github.com/apache/thrift/pull/3164#discussion_r2132415318
##########
.github/workflows/build.yml:
##########
@@ -552,20 +553,86 @@ jobs:
- name: Run ts tests
run: make -C lib/nodets check
+ lib-cpp:
+ needs: compiler
+ runs-on: ubuntu-24.04
+ steps:
+ - uses: actions/checkout@v4
+
+ - name: Install dependencies
+ run: |
+ sudo apt-get update -yq
+ sudo apt-get install -y --no-install-recommends g++ $BUILD_DEPS
locales
+ sudo locale-gen en_US.UTF-8
+ sudo locale-gen de_DE.UTF-8
Review Comment:
is this one needed?
##########
.github/workflows/build.yml:
##########
@@ -577,14 +644,17 @@ jobs:
- uses: actions/setup-java@v4
with:
distribution: temurin
- # here we intentionally use an older version so that we also verify
Java 17 compiles to it
Review Comment:
the comment about java 17 is _probably_ a typo? the one we want to make sure
is probably java 7 not 17?
I can't remember the exact details but I think we do want to maintain
compatibility with older lts java versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
