CJCombrink commented on code in PR #3164:
URL: https://github.com/apache/thrift/pull/3164#discussion_r2131622637
##########
lib/cpp/test/OneWayHTTPTest.cpp:
##########
@@ -202,10 +202,10 @@ BOOST_AUTO_TEST_CASE( JSON_BufferedHTTP )
#endif
{
- std::shared_ptr<TSocket> socket(new TSocket("localhost", port));
+ std::shared_ptr<TSocket> socket(new TSocket("127.0.0.1", port));
Review Comment:
This appears to be an issue with `localhost` getting resolved to the IPv6
address `::1` and stuff breaks.
I am actually reconsidering this commit and instead for the pipeline purge
the IPv6 `::1 localhost` from the `/etc/hosts` file in the pipeline.
_Or one that knows more about IPv6 and the socket libs used can perhaps see
if this can be fixed in the library; I don't know enough of IPv6 and the
libraries used to know if this is even an option_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
