ctubbsii commented on code in PR #3043:
URL: https://github.com/apache/thrift/pull/3043#discussion_r1828512723
##########
lib/kotlin/cross-test-server/build.gradle.kts:
##########
@@ -48,12 +48,6 @@ dependencies {
testImplementation("org.jetbrains.kotlin:kotlin-test-junit")
}
-kotlin {
- jvmToolchain {
- (this as
JavaToolchainSpec).languageVersion.set(JavaLanguageVersion.of(8))
- }
-}
-
Review Comment:
The change is fine with me. I think it's good to explicit whenever doing
compilation, whether compiling test code or not. But, I don't think it makes
any substantive difference here. So, if omitting it here doesn't cause any
problems, it is fine with me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
