fishy commented on code in PR #3051:
URL: https://github.com/apache/thrift/pull/3051#discussion_r1797242179
##########
lib/go/test/ClientMiddlewareExceptionTest.thrift:
##########
@@ -25,11 +25,11 @@ exception Exception2 {
// This is a special case, we want to make sure that the middleware don't
// accidentally pull result as error.
-exception FooResponse {
+struct/*exception*/ FooResponse { // returning an exception by any means
other than "throws" is illegal
Review Comment:
the purpose of this test is to verify that the library code does not have a
bug to accidentally pull the exception response out as the thrown exception, so
this change will actually make the test always pass even if someone introduces
such a bug in the future.
but if your plan is to forbid that on the compiler level so this scenario
would never happen in the first place, then I think this is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
